Remove com.ibm.icu.source from not-loaded bundle allowlists#2978
Merged
Conversation
ICU is no longer a dependency of this repo, so the entries in the 'should not be loaded/activated' bundle lists are dead and can be removed.
vogella
force-pushed
the
remove-icu-test-references
branch
from
ef236e4 to
79dc15a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICU is no longer a dependency of this repo, so the
com.ibm.icu.sourceentries in the not-loaded bundle allowlists in JavaActivationTest and PluginsNotLoadedTest are dead. The tests guard that certain bundles are never activated by the Java editor; without ICU on the classpath the entries can never match anything.